----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70096/#review217201 -----------------------------------------------------------
Can you maybe clarify in the commit description what the advantage of having this in a separate file is? This is going to clutter the source dir with a very visible, screaming-case `CPPLINT.cfg` file, so all other things being equal it seems like passing these settings via command-line instead would be preferrable? - Benno Evers On March 3, 2019, 1:01 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70096/ > ----------------------------------------------------------- > > (Updated March 3, 2019, 1:01 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Moved cpplint configuration into dedicated file. > > > Diffs > ----- > > bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c > support/CPPLINT.cfg PRE-CREATION > support/mesos-style.py b14820a1efe32c9c6e093b6f9cea93cb55ec97e4 > > > Diff: https://reviews.apache.org/r/70096/diff/2/ > > > Testing > ------- > > * confirmed that `./support/mesos-style.py src/executor/executor.cpp` still > does what is expected > * no new warnings when running over the whole codebase > > > Thanks, > > Benjamin Bannier > >
