----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70096/#review217457 -----------------------------------------------------------
Fix it, then Ship it! bootstrap.bat Lines 60 (patched) <https://reviews.apache.org/r/70096/#comment304721> s/mlink/mklink/ - Joseph Wu On Aug. 14, 2019, 4:25 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70096/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2019, 4:25 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9630 > https://issues.apache.org/jira/browse/MESOS-9630 > > > Repository: mesos > > > Description > ------- > > With this change we not only reduce the amount of code in > `support/mesos-style.py` in favor of a configuration supported by > upstream, but we also make it easier to interoperate with editor > integrations for cpplint. > > > Diffs > ----- > > bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c > bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 > support/CPPLINT.cfg PRE-CREATION > support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b > support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27 > > > Diff: https://reviews.apache.org/r/70096/diff/7/ > > > Testing > ------- > > * confirmed that `./support/mesos-style.py src/executor/executor.cpp` still > does what is expected > * no new warnings when running over the whole codebase > > > Thanks, > > Benjamin Bannier > >
