-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71205/
-----------------------------------------------------------

(Updated Aug. 19, 2019, 9:20 a.m.)


Review request for mesos and Till Toenshoff.


Changes
-------

Rebase; install config via link to allow for untracked modifications


Bugs: MESOS-9630
    https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
-------

This patch switches commit hooks to be orchestrated by the pre-commit
tool mirroring the previous linters invoked through git commit
hooks (orchestrated by `support/mesos-style.py` or standalone hooks).

Using pre-commit removes the burden of maintaining
`support/mesos-style.py`, making sure that hooks have the expected
environment (e.g., Python version, Node installed). Additionally,
upstream provides a number of additional linters which are not hard to
add to Mesos' hooks.


Diffs (updated)
-----

  docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c 
  support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
  support/pre-commit-config.yaml PRE-CREATION 
  support/setup-dev.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
  support/setup-dev.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/71205/diff/7/

Changes: https://reviews.apache.org/r/71205/diff/6-7/


Testing
-------

* used successfully for a couple of months


Thanks,

Benjamin Bannier

Reply via email to