----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71205/#review217439 -----------------------------------------------------------
Fix it, then Ship it! When running the script, I noticed this ``` [INFO] Installing environment for local. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for local. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... ``` Why do we seemingly repeat that step? After this all further steps were non duplicated. docs/advanced-contribution.md Line 67 (original), 68 (patched) <https://reviews.apache.org/r/71205/#comment304711> "The hooks are set up with `./support/setup_dev.sh`" We have to invoke it, so it does not really do much automatically, I'ld argue. support/setup-dev.sh Lines 57 (patched) <https://reviews.apache.org/r/71205/#comment304712> We generally strive for capitalizing product names - so let's have it this `Mesos` way everywhere please :) support/setup-dev.sh Lines 62 (patched) <https://reviews.apache.org/r/71205/#comment304710> Shouldnt there be an `exit(1)` here so we spare our users three more error messages? - Till Toenshoff On Aug. 20, 2019, 11:48 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71205/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2019, 11:48 a.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-9630 > https://issues.apache.org/jira/browse/MESOS-9630 > > > Repository: mesos > > > Description > ------- > > This patch switches commit hooks to be orchestrated by the pre-commit > tool mirroring the previous linters invoked through git commit > hooks (orchestrated by `support/mesos-style.py` or standalone hooks). > > Using pre-commit removes the burden of maintaining > `support/mesos-style.py`, making sure that hooks have the expected > environment (e.g., Python version, Node installed). Additionally, > upstream provides a number of additional linters which are not hard to > add to Mesos' hooks. > > > Diffs > ----- > > docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c > support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b > support/pre-commit-config.yaml PRE-CREATION > support/setup-dev.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 > support/setup-dev.sh PRE-CREATION > > > Diff: https://reviews.apache.org/r/71205/diff/8/ > > > Testing > ------- > > * used successfully for a couple of months > > > Thanks, > > Benjamin Bannier > >
