----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71347/#review217374 -----------------------------------------------------------
Patch looks great! Reviews applied: [71345, 71346, 71347] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Aug. 22, 2019, 12:31 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71347/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2019, 12:31 a.m.) > > > Review request for mesos, Andrei Sekretenko and Meng Zhu. > > > Bugs: MESOS-9806 > https://issues.apache.org/jira/browse/MESOS-9806 > > > Repository: mesos > > > Description > ------- > > There are several optimization used here: > > * Avoid unnecessary copying of Resource objects. > * Avoid unnecessary validation. > > The shrinkResources function now is a friend of Resources, > in order to perform an in-place shuffle of the vector. > > Master branch: > HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2 > Made 3500 allocations in 36.1185929secs > Made 0 allocation in 32.62218602secs > > After all patches in review chain: > HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2 > Made 3500 allocations in 21.389381617secs > Made 0 allocation in 18.593000222secs > > > Diffs > ----- > > include/mesos/resource_quantities.hpp > c861df8a8a167b19ea8374c22cdd2a8fe567a6a6 > include/mesos/resources.hpp a6a052ba51e13e2804eca846f08605e7f0714cfd > include/mesos/v1/resources.hpp e43d1fba69771405f4575cf675d6f0cd13c2c7c9 > src/common/resource_quantities.cpp 9577181bc4c05214759332e41f4a7d8b8fb6db1f > src/common/resources.cpp fc7e86ba5eee3deb953d85065a1192374910c5e5 > src/common/resources_utils.cpp 720b954b74a5db72438b1846d7df837d6a1fa4a4 > src/v1/resources.cpp 88da0a185bd54e7053a221fe0b3255f3c514ac60 > > > Diff: https://reviews.apache.org/r/71347/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
