----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71347/#review217401 -----------------------------------------------------------
Patch looks great! Reviews applied: [71353, 71354, 71347] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Aug. 22, 2019, 3:34 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71347/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2019, 3:34 p.m.) > > > Review request for mesos, Andrei Sekretenko and Meng Zhu. > > > Bugs: MESOS-9806 > https://issues.apache.org/jira/browse/MESOS-9806 > > > Repository: mesos > > > Description > ------- > > The shrinkResources function now is a friend of Resources, > in order to perform an in-place shuffle of the vector. > > Master + previous patches: > *HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2 > Made 3500 allocations in 23.37 secs > Made 0 allocation in 19.72 secs > > Master + previous patches + this patch: > *HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2 > Made 3500 allocations in 21.71 secs > Made 0 allocation in 18.49 secs > > > Diffs > ----- > > include/mesos/resources.hpp a6a052ba51e13e2804eca846f08605e7f0714cfd > src/common/resources_utils.cpp 720b954b74a5db72438b1846d7df837d6a1fa4a4 > > > Diff: https://reviews.apache.org/r/71347/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
