> On Aug. 23, 2019, 6:24 p.m., Benjamin Mahler wrote: > > include/mesos/resource_quantities.hpp > > Lines 121-124 (original), 122-127 (patched) > > <https://reviews.apache.org/r/71355/diff/2/?file=2162739#file2162739line123> > > > > "small_vector<T, N, Allocator> is convertible to small_vector_base<T, > > Allocator> that is independent from the preallocated element capacity, so > > client code does not need to be templated on that N argument." > > > > Is it possible to expose the non-sized version to the clients? i.e. > > > > ``` > > boost::container::small_vector<std::pair<std::string, > > Value::Scalar>>::const_iterator > > ```
Whoops, small_vector -> small_vector_base - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71355/#review217404 ----------------------------------------------------------- On Aug. 22, 2019, 11:58 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71355/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2019, 11:58 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9806 > https://issues.apache.org/jira/browse/MESOS-9806 > > > Repository: mesos > > > Description > ------- > > Master > *HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2 > Made 3500 allocations in 23.37 secs > Made 0 allocation in 19.72 secs > > Master + this patch: > *HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2 > Made 3500 allocations in 22.065721878secs > Made 0 allocation in 19.467366742secs > > > Diffs > ----- > > include/mesos/resource_quantities.hpp > cdb34271868ab5931d7e35273af1219824d4d5b9 > src/common/resource_quantities.cpp 7c7ede32fd6e5aa4a960a8ca030b5aba115200f6 > > > Diff: https://reviews.apache.org/r/71355/diff/2/ > > > Testing > ------- > > make check > benchmark result in description > > > Thanks, > > Meng Zhu > >
