----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71355/#review217413 -----------------------------------------------------------
Fix it, then Ship it! src/common/resource_quantities.cpp Lines 155-157 (original), 150-153 (patched) <https://reviews.apache.org/r/71355/#comment304694> Is there a cleaner way to add const-ness? E.g. ``` const auto& self = *this; return self.begin(); ``` - Benjamin Mahler On Aug. 23, 2019, 7:44 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71355/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2019, 7:44 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9806 > https://issues.apache.org/jira/browse/MESOS-9806 > > > Repository: mesos > > > Description > ------- > > Master + previous patch > *HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2 > Made 3500 allocations in 16.831380548secs > Made 0 allocation in 15.102885644secs > > Master + previous patch + this patch: > *HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2 > Made 3500 allocations in 16.307044003secs > Made 0 allocation in 14.948262599secs > > > Diffs > ----- > > include/mesos/resource_quantities.hpp > cdb34271868ab5931d7e35273af1219824d4d5b9 > src/common/resource_quantities.cpp 7c7ede32fd6e5aa4a960a8ca030b5aba115200f6 > > > Diff: https://reviews.apache.org/r/71355/diff/3/ > > > Testing > ------- > > make check > benchmark result in description > > > Thanks, > > Meng Zhu > >
