> On Sept. 17, 2019, 10:12 p.m., Meng Zhu wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Lines 134 (patched) > > <https://reviews.apache.org/r/71488/diff/2/?file=2165555#file2165555line134> > > > > why not resource quantities? what matter data do we need?
I've removed exposing allocated scalars altogether (in favour of `consumedQuota()` method in the next patch). However, I don't see a simple way to correctly account for shared resources without storing them, so `allocaredScalars_` has to be `Resources` anyway. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71488/#review217798 ----------------------------------------------------------- On Sept. 18, 2019, 5:07 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71488/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2019, 5:07 p.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Bugs: MESOS-9949 > https://issues.apache.org/jira/browse/MESOS-9949 > > > Repository: mesos > > > Description > ------- > > Track per-role allocated resources in the roles tree. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 5ea37912dadded47eaa2d354889c95533b191c59 > src/master/allocator/mesos/hierarchical.cpp > 256fdce61ccfb768605cac1579c9a6632cd26fec > > > Diff: https://reviews.apache.org/r/71488/diff/3/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
