-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71488/#review218029
-----------------------------------------------------------




src/master/allocator/mesos/hierarchical.hpp
Lines 196 (patched)
<https://reviews.apache.org/r/71488/#comment305494>

    I would appreciate if further explaination is added to allocated :)
    
    (i.e. resources used for launching tasks)



src/master/allocator/mesos/hierarchical.hpp
Lines 412 (patched)
<https://reviews.apache.org/r/71488/#comment305499>

    why do we need to track this in the agent?
    
    Also, need to include this change in the summary and description.


- Meng Zhu


On Sept. 27, 2019, 6:08 a.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71488/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2019, 6:08 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9949
>     https://issues.apache.org/jira/browse/MESOS-9949
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Track per-role allocated resources in the roles tree.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> d42124f534536ad044bff9878d242892fa042f24 
>   src/master/allocator/mesos/hierarchical.cpp 
> 47281542792486854b71c7e75dfa8ea3ee3ef3fc 
> 
> 
> Diff: https://reviews.apache.org/r/71488/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Reply via email to