-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71639/
-----------------------------------------------------------
(Updated Oct. 23, 2019, 7:56 p.m.)
Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
Summary (updated)
-----------------
Added an benchmark for `allocator->UpdateAllocation()`.
Bugs: MESOS-10016
https://issues.apache.org/jira/browse/MESOS-10016
Repository: mesos
Description (updated)
-------
This benchmark evaluates the performance of
`allocator->UpdateAllocation()` where the agent has various
sizes of resource reservations.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp
38fd19cee6409e4daa5bb0ab523e8e464cdcc9a5
Diff: https://reviews.apache.org/r/71639/diff/2/
Changes: https://reviews.apache.org/r/71639/diff/1-2/
Testing (updated)
-------
On the master branch optimized build:
```
[ RUN ]
ResourceParam/HierarchicalAllocator__BENCHMARK_WithResourceParam.UpdateAllocation/0
Agent resources size: 50 (50 roles, 1 reservations per role, 1 ranges per port
resources)
20 reservation operations took 442.402455ms, each takes 22.120122ms
20 Unreservation operations took 464.085487ms, each takes 23.204274ms
[ RUN ]
ResourceParam/HierarchicalAllocator__BENCHMARK_WithResourceParam.UpdateAllocation/1
Agent resources size: 100 (100 roles, 1 reservations per role, 1 ranges per
port resources)
20 reservation operations took 1.321309035secs, each takes 66.065451ms
20 Unreservation operations took 1.311244246secs, each takes 65.562212ms
[ RUN ]
ResourceParam/HierarchicalAllocator__BENCHMARK_WithResourceParam.UpdateAllocation/2
Agent resources size: 200 (200 roles, 1 reservations per role, 1 ranges per
port resources)
20 reservation operations took 4.129166934secs, each takes 206.458346ms
20 Unreservation operations took 4.041358384secs, each takes 202.067919ms
[ RUN ]
ResourceParam/HierarchicalAllocator__BENCHMARK_WithResourceParam.UpdateAllocation/3
Agent resources size: 400 (400 roles, 1 reservations per role, 1 ranges per
port resources)
20 reservation operations took 15.011075671secs, each takes 750.553783ms
20 Unreservation operations took 15.41327483secs, each takes 770.663741ms
[ RUN ]
ResourceParam/HierarchicalAllocator__BENCHMARK_WithResourceParam.UpdateAllocation/4
Agent resources size: 600 (600 roles, 1 reservations per role, 1 ranges per
port resources)
20 reservation operations took 31.159754828secs, each takes 1.557987741secs
20 Unreservation operations took 30.69454178secs, each takes 1.534727089secs
```
Thanks,
Meng Zhu