----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71639/#review218432 -----------------------------------------------------------
Patch looks great! Reviews applied: [71639] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Oct. 29, 2019, 3:43 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71639/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2019, 3:43 a.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Bugs: MESOS-10016 > https://issues.apache.org/jira/browse/MESOS-10016 > > > Repository: mesos > > > Description > ------- > > This benchmark evaluates the performance of > `allocator->UpdateAllocation()` where the agent has various > sizes of resource reservations. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 38fd19cee6409e4daa5bb0ab523e8e464cdcc9a5 > > > Diff: https://reviews.apache.org/r/71639/diff/3/ > > > Testing > ------- > > On the master branch optimized build: > > ``` > [ RUN ] > ResourceParam/HierarchicalAllocator__BENCHMARK_WithResourceParam.UpdateAllocation/0 > Agent resources size: 50 (50 roles, 1 reservations per role, 1 ranges per > port resource) > 20 RESERVE operations took 1.968569746secs, each takes 98.428487ms > 20 UNRESERVE operations took 1.978470742secs, each takes 98.923537ms > [ OK ] > ResourceParam/HierarchicalAllocator__BENCHMARK_WithResourceParam.UpdateAllocation/0 > (3996 ms) > [ RUN ] > ResourceParam/HierarchicalAllocator__BENCHMARK_WithResourceParam.UpdateAllocation/1 > Agent resources size: 100 (100 roles, 1 reservations per role, 1 ranges per > port resource) > 20 RESERVE operations took 10.094084426secs, each takes 504.704221ms > 20 UNRESERVE operations took 10.293614069secs, each takes 514.680703ms > [ OK ] > ResourceParam/HierarchicalAllocator__BENCHMARK_WithResourceParam.UpdateAllocation/1 > (20584 ms) > [ RUN ] > ResourceParam/HierarchicalAllocator__BENCHMARK_WithResourceParam.UpdateAllocation/2 > Agent resources size: 200 (200 roles, 1 reservations per role, 1 ranges per > port resource) > 20 RESERVE operations took 1.16018705933333mins, each takes 3.480561178secs > 20 UNRESERVE operations took 1.17209781845mins, each takes 3.516293455secs > [ OK ] > ResourceParam/HierarchicalAllocator__BENCHMARK_WithResourceParam.UpdateAllocation/2 > (141363 ms) > ``` > > > Thanks, > > Meng Zhu > >
