----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71641/#review218442 -----------------------------------------------------------
src/master/master.cpp Lines 7848 (patched) <https://reviews.apache.org/r/71641/#comment306165> s/instrucing/instructing/ src/master/master.cpp Lines 7851 (patched) <https://reviews.apache.org/r/71641/#comment306166> s/message tasks/message, tasks/ src/tests/master_tests.cpp Lines 11107 (patched) <https://reviews.apache.org/r/71641/#comment306170> Is this what you're confirming here? Looks like you're making sure the task is not listed as completed? I think we want to verify both: 1) The task is not still in TASK_LOST (i.e. `completed_tasks` is empty) 2) The task is in the list of running tasks - Greg Mann On Oct. 28, 2019, 5:53 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71641/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2019, 5:53 p.m.) > > > Review request for mesos, Benno Evers, Benjamin Mahler, and Greg Mann. > > > Bugs: MESOS-10018 > https://issues.apache.org/jira/browse/MESOS-10018 > > > Repository: mesos > > > Description > ------- > > Under certain conditions tasks which were previously `TASK_LOST` and > completed can reappear in non-terminal states, e.g., if the agent on > which they where running reconnect. > > This patch adds garbage collection of such completed tasks so that users > do not see tasks twice when obtaining task information from the master > API. This change does not affect tasks status updates where we already > correctly reported a previously `TASK_LOST` state as superseded by e.g., > `TASK_RUNNING`. > > > Diffs > ----- > > src/master/master.cpp 351823e69f14dbb5eb1ea2b108c42e93722f1eff > src/tests/master_tests.cpp 5486e23ce146eda9191e081a48c1f3fcb52a7569 > > > Diff: https://reviews.apache.org/r/71641/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
