----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71641/#review218466 -----------------------------------------------------------
Fix it, then Ship it! src/master/master.cpp Lines 7847 (patched) <https://reviews.apache.org/r/71641/#comment306207> s/task/tasks/ s/to terminal state/to a terminal state/ src/master/master.cpp Lines 7855 (patched) <https://reviews.apache.org/r/71641/#comment306208> s/collected/collecting/ src/tests/master_tests.cpp Lines 10940-10941 (original), 10942-10944 (patched) <https://reviews.apache.org/r/71641/#comment306209> One more newline here. src/tests/master_tests.cpp Lines 11128 (patched) <https://reviews.apache.org/r/71641/#comment306210> Looks like the compiler is complaining about a type mismatch here. - Greg Mann On Oct. 30, 2019, 12:27 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71641/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2019, 12:27 p.m.) > > > Review request for mesos, Benno Evers, Benjamin Mahler, and Greg Mann. > > > Bugs: MESOS-10018 > https://issues.apache.org/jira/browse/MESOS-10018 > > > Repository: mesos > > > Description > ------- > > Under certain conditions tasks which were previously `TASK_LOST` and > completed can reappear in non-terminal states, e.g., if the agent on > which they where running reconnect. > > This patch adds garbage collection of such completed tasks so that users > do not see tasks twice when obtaining task information from the master > API. This change does not affect tasks status updates where we already > correctly reported a previously `TASK_LOST` state as superseded by e.g., > `TASK_RUNNING`. > > > Diffs > ----- > > src/master/master.cpp 351823e69f14dbb5eb1ea2b108c42e93722f1eff > src/tests/master_tests.cpp 5486e23ce146eda9191e081a48c1f3fcb52a7569 > > > Diff: https://reviews.apache.org/r/71641/diff/4/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
