----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71659/#review218572 -----------------------------------------------------------
cmake/CompilationConfigure.cmake Lines 263-268 (original) <https://reviews.apache.org/r/71659/#comment306307> We need to update the autotools build to allow this as well, right? docs/ssl.md Line 7 (original), 7 (patched) <https://reviews.apache.org/r/71659/#comment306308> The 'enable-ssl' section of 'docs/configuration/autotools.md' needs to be updated as well. docs/ssl.md Line 15 (original), 18 (patched) <https://reviews.apache.org/r/71659/#comment306305> s/only// ? docs/ssl.md Lines 17-19 (original), 33-35 (patched) <https://reviews.apache.org/r/71659/#comment306306> Let's be more explicit here that users can use `enable-ssl` both with or without `enable-libevent`. - Greg Mann On Oct. 23, 2019, 7:37 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71659/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2019, 7:37 p.m.) > > > Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till > Toenshoff. > > > Bugs: MESOS-10009 > https://issues.apache.org/jira/browse/MESOS-10009 > > > Repository: mesos > > > Description > ------- > > This removes the configure-time check on having both > ENABLE_SSL and ENABLE_LIBEVENT set to true in order to have > SSL sockets. The subsequent commits will add SSL support > to the poll socket class as a wrapper. > > This also updates the related documentation for SSL, > including on Windows. > > > Diffs > ----- > > cmake/CompilationConfigure.cmake 62cb23e81abb2c7e4e8e13c83b45afb98708bd30 > docs/ssl.md f6beb4211f0c17fdaa4b52425cec405c9b6a7d56 > docs/windows.md 35b12ddedec6f85b75adefa80d38fa439cd6b2d3 > > > Diff: https://reviews.apache.org/r/71659/diff/1/ > > > Testing > ------- > > Requires a libprocess build change too (next patch). > > > Thanks, > > Joseph Wu > >
