----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71659/#review218658 -----------------------------------------------------------
Fix it, then Ship it! docs/ssl.md Lines 12 (patched) <https://reviews.apache.org/r/71659/#comment306517> s/encypts/encrypts/ Also, I know it isn't your sentence, but "the communication that Mesos uses for communication" doesn't sound entirely correct either. - Benno Evers On Nov. 13, 2019, 7:01 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71659/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2019, 7:01 p.m.) > > > Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till > Toenshoff. > > > Bugs: MESOS-10009 > https://issues.apache.org/jira/browse/MESOS-10009 > > > Repository: mesos > > > Description > ------- > > This removes the configure-time check on having both > ENABLE_SSL and ENABLE_LIBEVENT set to true in order to have > SSL sockets. The subsequent commits will add SSL support > to the poll socket class as a wrapper. > > This also updates the related documentation for SSL, > including on Windows. > > > Diffs > ----- > > cmake/CompilationConfigure.cmake 62cb23e81abb2c7e4e8e13c83b45afb98708bd30 > configure.ac f274f34e6982beb0a5a683526f7eb9c4ea744e40 > docs/configuration/autotools.md 55a5de83729271b043bd1b8de67798ab52b195c6 > docs/ssl.md f6beb4211f0c17fdaa4b52425cec405c9b6a7d56 > docs/windows.md 35b12ddedec6f85b75adefa80d38fa439cd6b2d3 > > > Diff: https://reviews.apache.org/r/71659/diff/2/ > > > Testing > ------- > > Requires a libprocess build change too (next patch). > > > Thanks, > > Joseph Wu > >
