> On Nov. 21, 2019, 6:09 p.m., Andrei Sekretenko wrote: > > src/master/http.cpp > > Lines 2445 (patched) > > <https://reviews.apache.org/r/71755/diff/1/?file=2172071#file2172071line2445> > > > > `default`? So that we do not rely on content-type validation in > > preceding code. > > > > (also see the build warning)
I instinctively avoided the use of `default` given we tend to enumerate all cases to help catch missing logic when new cases are added (since that will result in a compiler error for our build), but thinking about this again, this does indeed seem like a good case for `default`: - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71755/#review218735 ----------------------------------------------------------- On Nov. 19, 2019, 7:43 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71755/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2019, 7:43 p.m.) > > > Review request for mesos, Andrei Sekretenko, Greg Mann, and Meng Zhu. > > > Bugs: MESOS-10026 > https://issues.apache.org/jira/browse/MESOS-10026 > > > Repository: mesos > > > Description > ------- > > This follow the same approach used in the GetAgents call; > serializing directly to protobuf or json from the in-memory > v0 state. > > > Diffs > ----- > > src/master/http.cpp 60765c9b9d6903f6ed94fa8c614055698caad0da > > > Diff: https://reviews.apache.org/r/71755/diff/1/ > > > Testing > ------- > > > Thanks, > > Benjamin Mahler > >
