> On Nov. 21, 2019, 6:02 p.m., Andrei Sekretenko wrote: > > Overall looks good to me (and probably this one is more permanent than > > 71750-71754, as the metrcis have a simple strictire which is not likely to > > change, I'd guess). > > > > Do you have any results of benchmarking v1::GetMetrics before/after this vs > > /metrics/snapshot ? > > Andrei Sekretenko wrote: > s/strictire/structure/
Yeah this one is likely more permanent, we currently don't have a benchmark for GetMetrics (but we do have some for the underlying metrics library). Since the same principle was at play I didn't bother adding a specific benchmark for this call (need a setup which generates large numbers of metrics). - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71755/#review218719 ----------------------------------------------------------- On Nov. 19, 2019, 7:43 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71755/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2019, 7:43 p.m.) > > > Review request for mesos, Andrei Sekretenko, Greg Mann, and Meng Zhu. > > > Bugs: MESOS-10026 > https://issues.apache.org/jira/browse/MESOS-10026 > > > Repository: mesos > > > Description > ------- > > This follow the same approach used in the GetAgents call; > serializing directly to protobuf or json from the in-memory > v0 state. > > > Diffs > ----- > > src/master/http.cpp 60765c9b9d6903f6ed94fa8c614055698caad0da > > > Diff: https://reviews.apache.org/r/71755/diff/1/ > > > Testing > ------- > > > Thanks, > > Benjamin Mahler > >
