----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71664/#review218800 -----------------------------------------------------------
3rdparty/libprocess/src/ssl/socket_wrapper.cpp Lines 115 (patched) <https://reviews.apache.org/r/71664/#comment306665> Nit: end line with a period. 3rdparty/libprocess/src/ssl/socket_wrapper.cpp Lines 166-167 (patched) <https://reviews.apache.org/r/71664/#comment306669> This is a bit hard for me to understand, maybe something like "This assumption allows us to avoid copying the read bytes every time this function is called." 3rdparty/libprocess/src/ssl/socket_wrapper.cpp Lines 212-215 (patched) <https://reviews.apache.org/r/71664/#comment306670> Are we sure that there are no ill effects of immediately returning 1 here, even when there may still be data left to be flushed? - Greg Mann On Nov. 19, 2019, 8:16 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71664/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2019, 8:16 p.m.) > > > Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till > Toenshoff. > > > Bugs: MESOS-10009 > https://issues.apache.org/jira/browse/MESOS-10009 > > > Repository: mesos > > > Description > ------- > > This implements the OpenSSL basic I/O abstraction based on the > libprocess event loop. This BIO wraps a socket and handles the > reading/writing, using io::read and io::write. > > This BIO can be passed into an SSL context to enable usage of > SSL translation functions like SSL_read and SSL_write. > > > Diffs > ----- > > 3rdparty/libprocess/src/ssl/socket_wrapper.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/71664/diff/3/ > > > Testing > ------- > > cmake --build . --target process > > A tiny bit of testing next patch. > > > Thanks, > > Joseph Wu > >
