----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71664/#review219032 -----------------------------------------------------------
3rdparty/libprocess/src/ssl/openssl_socket.cpp Lines 45 (patched) <https://reviews.apache.org/r/71664/#comment307062> Maybe rename this now that the implementation has been renamed? A couple random ideas: `OpenSSLBIOData`, `LibprocessBIOData` 3rdparty/libprocess/src/ssl/openssl_socket.cpp Lines 48 (patched) <https://reviews.apache.org/r/71664/#comment307064> s/SSLSocketWrapper/OpenSSLSocketImpl/ Here and elsewhere 3rdparty/libprocess/src/ssl/openssl_socket.cpp Lines 165-170 (patched) <https://reviews.apache.org/r/71664/#comment307067> Who provides this guarantee? Might this break if the libprocess callsites change in the future? 3rdparty/libprocess/src/ssl/openssl_socket.cpp Lines 166-167 (patched) <https://reviews.apache.org/r/71664/#comment307066> s/onto same/onto the same/ 3rdparty/libprocess/src/ssl/openssl_socket.cpp Lines 188 (patched) <https://reviews.apache.org/r/71664/#comment307065> Could you include a comment in/around this function explaining a bit more how we determined which enums needed to be handled here, and which didn't? - Greg Mann On Dec. 10, 2019, 11:52 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71664/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2019, 11:52 p.m.) > > > Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till > Toenshoff. > > > Bugs: MESOS-10009 > https://issues.apache.org/jira/browse/MESOS-10009 > > > Repository: mesos > > > Description > ------- > > This implements the OpenSSL basic I/O abstraction based on the > libprocess event loop. This BIO wraps a socket and handles the > reading/writing, using io::read and io::write. > > This BIO can be passed into an SSL context to enable usage of > SSL translation functions like SSL_read and SSL_write. > > > Diffs > ----- > > 3rdparty/libprocess/src/ssl/openssl_socket.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/71664/diff/4/ > > > Testing > ------- > > cmake --build . --target process > > A tiny bit of testing next patch. > > > Thanks, > > Joseph Wu > >
