----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71666/#review219029 -----------------------------------------------------------
3rdparty/libprocess/src/ssl/openssl_socket.cpp Lines 478 (patched) <https://reviews.apache.org/r/71666/#comment307057> Is it possible that a client-initiated renegotiation will lead to an SSL_ERROR_WANT_READ result here? Would we hang in that case? Same question for an SSL_ERROR_WANT_WRITE result in `recv()`. 3rdparty/libprocess/src/ssl/openssl_socket.cpp Lines 683 (patched) <https://reviews.apache.org/r/71666/#comment307056> Maybe s/Server sockets/Listening sockets/ Since accepted server-side sockets will create a UPID. - Greg Mann On Dec. 10, 2019, 11:55 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71666/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2019, 11:55 p.m.) > > > Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till > Toenshoff. > > > Bugs: MESOS-10010 > https://issues.apache.org/jira/browse/MESOS-10010 > > > Repository: mesos > > > Description > ------- > > This completes a fully functional client-side SSL socket. > > Needs a bit of cleanup and more error handling though. > > > Diffs > ----- > > 3rdparty/libprocess/src/ssl/openssl_socket.hpp PRE-CREATION > 3rdparty/libprocess/src/ssl/openssl_socket.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/71666/diff/7/ > > > Testing > ------- > > ``` > cmake --build . --target libprocess-tests > libprocess-tests > ``` > > Running libprocess-tests yields: > ``` > [ FAILED ] SSLTest.ValidDowngrade > [ FAILED ] SSLTest.ValidDowngradeEachProtocol > ``` > > > Thanks, > > Joseph Wu > >
