> On Dec. 13, 2019, 11:41 a.m., Greg Mann wrote: > > 3rdparty/libprocess/src/ssl/openssl_socket.cpp > > Lines 478 (patched) > > <https://reviews.apache.org/r/71666/diff/7/?file=2183605#file2183605line478> > > > > Is it possible that a client-initiated renegotiation will lead to an > > SSL_ERROR_WANT_READ result here? Would we hang in that case? > > > > Same question for an SSL_ERROR_WANT_WRITE result in `recv()`.
https://issues.apache.org/jira/browse/MESOS-10070 We have reason to believe the OpenSSL library may handle this transparently for us, but a unit test would make sure of this. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71666/#review219029 ----------------------------------------------------------- On Dec. 16, 2019, 2:05 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71666/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2019, 2:05 p.m.) > > > Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till > Toenshoff. > > > Bugs: MESOS-10010 > https://issues.apache.org/jira/browse/MESOS-10010 > > > Repository: mesos > > > Description > ------- > > This completes a fully functional client-side SSL socket. > > Needs a bit of cleanup and more error handling though. > > > Diffs > ----- > > 3rdparty/libprocess/src/ssl/openssl_socket.hpp PRE-CREATION > 3rdparty/libprocess/src/ssl/openssl_socket.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/71666/diff/8/ > > > Testing > ------- > > ``` > cmake --build . --target libprocess-tests > libprocess-tests > ``` > > Running libprocess-tests yields: > ``` > [ FAILED ] SSLTest.ValidDowngrade > [ FAILED ] SSLTest.ValidDowngradeEachProtocol > ``` > > > Thanks, > > Joseph Wu > >
