> On Jan. 8, 2020, 6:34 a.m., Greg Mann wrote: > > Is this still WIP? If not, could you update the commit message accordingly?
Yes, it is still WIP since I have not handled infinite memory limit yet. Once https://issues.apache.org/jira/browse/MESOS-10064 is resolved, I will update this patch accordingly. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71943/#review219157 ----------------------------------------------------------- On Jan. 5, 2020, 10:04 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71943/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2020, 10:04 p.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10048 > https://issues.apache.org/jira/browse/MESOS-10048 > > > Repository: mesos > > > Description > ------- > > WIP: Set container's `memory.limit_in_bytes` to its memory limit. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp > 0896d37761a11f55ba4b866d235c3bd2b79dcfba > > > Diff: https://reviews.apache.org/r/71943/diff/2/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
