----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71943/#review219879 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp Line 212 (original), 222-231 (patched) <https://reviews.apache.org/r/71943/#comment308123> I find this block a little unintuitive at first glance; perhaps a comment would help? ``` // Rather than trying to represent an infinite limit with // the `Bytes` type, we represent the infinite case by // setting `isInfiniteLimit` to `true` and letting // `hardLimit` be NONE. ``` src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp Lines 240 (patched) <https://reviews.apache.org/r/71943/#comment308122> Wrap at 80 characters. - Greg Mann On March 6, 2020, 8:33 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71943/ > ----------------------------------------------------------- > > (Updated March 6, 2020, 8:33 a.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10048 > https://issues.apache.org/jira/browse/MESOS-10048 > > > Repository: mesos > > > Description > ------- > > Set container's `memory.limit_in_bytes` to its memory limit. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.hpp > 27d88e91fb784179effd54781f84000fe85c13eb > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp > 0896d37761a11f55ba4b866d235c3bd2b79dcfba > > > Diff: https://reviews.apache.org/r/71943/diff/4/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
