> On Jan. 8, 2020, 7:07 a.m., Greg Mann wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp > > Lines 199 (patched) > > <https://reviews.apache.org/r/71944/diff/2/?file=2193218#file2193218line199> > > > > Do we really want to do this? My concern is that this will make any > > non-Mesos-task processes on the node (networking and security components, > > for example) more likely to be OOM-killed than Mesos tasks. Perhaps we > > should only set the OOM score adjustment for burstable tasks. What do you > > think?
I think it depends on which one is in higher priority and more important, guaranteed task or non-Mesos-task processes? In Kubernetes implementation (https://github.com/kubernetes/kubernetes/blob/v1.16.2/pkg/kubelet/qos/policy.go#L51:L53), the OOM score adjust of guaranteed container is set to -998, and kubelet's OOM score adjust is set to -998 too, I think we should do the same to protect guaranteed containers and Mesos agent, what do you think? - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71944/#review219158 ----------------------------------------------------------- On Jan. 5, 2020, 10:06 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71944/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2020, 10:06 p.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10048 > https://issues.apache.org/jira/browse/MESOS-10048 > > > Repository: mesos > > > Description > ------- > > Set container process's OOM score adjust. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.hpp > 27d88e91fb784179effd54781f84000fe85c13eb > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp > 0896d37761a11f55ba4b866d235c3bd2b79dcfba > > > Diff: https://reviews.apache.org/r/71944/diff/2/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > >
