----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71944/#review219189 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp Lines 202-207 (patched) <https://reviews.apache.org/r/71944/#comment307308> Unfortunately, this may set the OOM score adjust of default executor to a very big value (e.g., 999) if the task to be launched by the default executor has a small memory request. This is too risky, we'd better to set default executor's OOM score adjust to something like -998 to protect it. - Qian Zhang On Jan. 8, 2020, 11:28 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71944/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2020, 11:28 p.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10048 > https://issues.apache.org/jira/browse/MESOS-10048 > > > Repository: mesos > > > Description > ------- > > Set container process's OOM score adjust. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.hpp > 27d88e91fb784179effd54781f84000fe85c13eb > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp > 0896d37761a11f55ba4b866d235c3bd2b79dcfba > > > Diff: https://reviews.apache.org/r/71944/diff/3/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > >
