> On Feb. 3, 2020, 3:21 a.m., Qian Zhang wrote: > > src/slave/flags.cpp > > Lines 846-851 (original), 850-855 (patched) > > <https://reviews.apache.org/r/71991/diff/1/?file=2205595#file2205595line850> > > > > Not yours. `AGENT_OPERATION_FEEDBACK` requires `RESOURCE_PROVIDER` and > > we always requires `AGENT_OPERATION_FEEDBACK`, that means we always require > > `RESOURCE_PROVIDER`, right? So I think we should check > > `capabilities.resourceProvider` in L832 ~ L837.
Good point, I'll address this in a separate patch. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71991/#review219461 ----------------------------------------------------------- On Jan. 14, 2020, 2:12 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71991/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2020, 2:12 a.m.) > > > Review request for mesos, Andrei Budnik and Qian Zhang. > > > Bugs: MESOS-10044 > https://issues.apache.org/jira/browse/MESOS-10044 > > > Repository: mesos > > > Description > ------- > > This capability will be used by the master to detect whether > or not an agent can handle task resource limits. > > > Diffs > ----- > > include/mesos/mesos.proto b0f590545df720df644d049e9d8f1e81bdbe814c > include/mesos/v1/mesos.proto 53a7b9bc6190d826868a1633c11c9a0ecf9acf0a > src/common/protobuf_utils.hpp 3852f59986caf244a2512d10400298246e8ba8f1 > src/common/protobuf_utils.cpp 7fe4a44b1e7ded998dffb0490c1d61ced697ebd5 > src/slave/constants.cpp 1963890fd6c0eadaac174755609287ecf4211661 > src/slave/flags.cpp 7653c397cbf27490f7b071b5e151bcdf77e6478c > src/tests/master_tests.cpp 9688f5f0266f7c7142b54d488f2c13b427e542c0 > src/tests/slave_tests.cpp fd4fd6bd1baca0e4521999d2c08e6eab78e57a4f > > > Diff: https://reviews.apache.org/r/71991/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Greg Mann > >
