> On Feb. 3, 2020, 3:21 a.m., Qian Zhang wrote: > > src/slave/flags.cpp > > Lines 846-851 (original), 850-855 (patched) > > <https://reviews.apache.org/r/71991/diff/1/?file=2205595#file2205595line850> > > > > Not yours. `AGENT_OPERATION_FEEDBACK` requires `RESOURCE_PROVIDER` and > > we always requires `AGENT_OPERATION_FEEDBACK`, that means we always require > > `RESOURCE_PROVIDER`, right? So I think we should check > > `capabilities.resourceProvider` in L832 ~ L837. > > Greg Mann wrote: > Good point, I'll address this in a separate patch.
Follow-up patch is here: https://reviews.apache.org/r/72087/ - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71991/#review219461 ----------------------------------------------------------- On Feb. 5, 2020, 9:58 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71991/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2020, 9:58 p.m.) > > > Review request for mesos, Andrei Budnik and Qian Zhang. > > > Bugs: MESOS-10044 > https://issues.apache.org/jira/browse/MESOS-10044 > > > Repository: mesos > > > Description > ------- > > This capability will be used by the master to detect whether > or not an agent can handle task resource limits. > > > Diffs > ----- > > docs/configuration/agent.md 0e703d8173aa1e5cac205f9626ab014853a3acce > docs/upgrades.md afd9dbb607abea13f133917e1dd8a34c0eafaef1 > include/mesos/mesos.proto d0aed5a8db21263619d669291680c9b12be600c1 > include/mesos/v1/mesos.proto 06c4816201346b2ff8ecbadf3bb99141b522152e > src/common/protobuf_utils.hpp 3852f59986caf244a2512d10400298246e8ba8f1 > src/common/protobuf_utils.cpp 7fe4a44b1e7ded998dffb0490c1d61ced697ebd5 > src/slave/constants.cpp 1963890fd6c0eadaac174755609287ecf4211661 > src/slave/flags.cpp 0f159a354d8d90ffb37d0032a3d1b69998bbe53c > src/tests/master_tests.cpp 9688f5f0266f7c7142b54d488f2c13b427e542c0 > src/tests/slave_tests.cpp fd4fd6bd1baca0e4521999d2c08e6eab78e57a4f > > > Diff: https://reviews.apache.org/r/71991/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Greg Mann > >
