> On Feb. 7, 2020, 7:48 p.m., Benjamin Mahler wrote: > > Will you be able get this patch committed without waiting for all the > > dependencies to land? > > > > Could you add a bit of your thinking here into the description? I assume > > it's simply that we don't want callers to be mutating or calling non-const > > operations on these, but I also wonder if there was something else that > > triggered this change, so even if the description was just that latter > > desire, that would be helpful for the reader :) > > > > I held off on a ship it because of the addFramework change and some > > suggestions around that. Let me know your thoughts!
Yes, this one has no dependencies, is not a breaking change and can be committed first. This change is triggered only by the depending https://reviews.apache.org/r/72095/ - what I need is to limit modifications of connection-related state to methods of `Framework`. I have to agree that limiting read access to `http` doesn't make things better, thus I followed your suggestion and simply left `http() const` accessor. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72094/#review219527 ----------------------------------------------------------- On Feb. 12, 2020, 5:48 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72094/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2020, 5:48 p.m.) > > > Review request for mesos, Benjamin Mahler and Greg Mann. > > > Bugs: MESOS-10056 > https://issues.apache.org/jira/browse/MESOS-10056 > > > Repository: mesos > > > Description > ------- > > This is a prerequisite to localizing mutations of connection-related > state of `Framework` to a limited set of `Framework` methods > in the next patch. > > > Diffs > ----- > > src/master/framework.cpp e69a7c26d15ffffb3d147328032f996962387c96 > src/master/http.cpp eeaac88c893b43170e655f8bff1d57dd0f7bbfb2 > src/master/master.hpp c813e9fc855cfb1701ec32be7f690e06b6eb203f > src/master/master.cpp d41ae724ba12b5ad1c8ae3c1f9b91a05b0e46e7e > src/master/readonly_handler.cpp 40005a2ac2cc9dd6075425c184d220f0a2fbee99 > > > Diff: https://reviews.apache.org/r/72094/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Andrei Sekretenko > >
