----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72094/#review219561 -----------------------------------------------------------
Fix it, then Ship it! Looks good, just flagged two spots below, per our offline discussion, that would be good to pull out into a separate bug fix JIRA / patch, about leaving the heartbeaters running on disconnected and completed frameworks. src/master/master.cpp Line 3323 (original), 3322 (patched) <https://reviews.apache.org/r/72094/#comment307751> Per offline discussion, would be great to pull out the close -> closeHttpConnection change into a separate bug fix JIRA / patch in front of (or after) this refactor. src/master/master.cpp Line 10910 (original), 10909 (patched) <https://reviews.apache.org/r/72094/#comment307750> Per offline discussion, would be great to pull out the close -> closeHttpConnection change into a separate bug fix JIRA / patch in front of (or after) this refactor. - Benjamin Mahler On Feb. 12, 2020, 5:48 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72094/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2020, 5:48 p.m.) > > > Review request for mesos, Benjamin Mahler and Greg Mann. > > > Bugs: MESOS-10056 > https://issues.apache.org/jira/browse/MESOS-10056 > > > Repository: mesos > > > Description > ------- > > This is a prerequisite to localizing mutations of connection-related > state of `Framework` to a limited set of `Framework` methods > in the next patch. > > > Diffs > ----- > > src/master/framework.cpp e69a7c26d15ffffb3d147328032f996962387c96 > src/master/http.cpp eeaac88c893b43170e655f8bff1d57dd0f7bbfb2 > src/master/master.hpp c813e9fc855cfb1701ec32be7f690e06b6eb203f > src/master/master.cpp d41ae724ba12b5ad1c8ae3c1f9b91a05b0e46e7e > src/master/readonly_handler.cpp 40005a2ac2cc9dd6075425c184d220f0a2fbee99 > > > Diff: https://reviews.apache.org/r/72094/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Andrei Sekretenko > >
