----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72267/#review220079 -----------------------------------------------------------
Oh yeah forgot about this, thanks for adding it! docs/scheduler-http-api.md Lines 528 (patched) <https://reviews.apache.org/r/72267/#comment308366> I assume this is the same as when a role is suppressed via SUPPRESS call? docs/scheduler-http-api.md Lines 529-530 (patched) <https://reviews.apache.org/r/72267/#comment308367> Is this true? https://github.com/apache/mesos/blob/1.9.0/src/master/allocator/mesos/hierarchical.cpp#L765-L766 ``` suppressRoles(framework, suppressedRoles - oldSuppressedRoles); reviveRoles(framework, (oldSuppressedRoles - suppressedRoles) & newRoles); ``` 1. suppress roles that transitioned into supressed 2. revive roles that were transitioned out of supressed So, more like "For roles that were transitioned out of suppressed, offer filters (set by `ACCEPT`/`DECLINE`) will be cleared. Right? docs/scheduler-http-api.md Lines 534-535 (patched) <https://reviews.apache.org/r/72267/#comment308368> Huh? Which fields are being referred to here? docs/scheduler-http-api.md Lines 575-579 (patched) <https://reviews.apache.org/r/72267/#comment308369> Can you link to the ticket here? - Benjamin Mahler On March 25, 2020, 2:08 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72267/ > ----------------------------------------------------------- > > (Updated March 25, 2020, 2:08 p.m.) > > > Review request for mesos, Benjamin Mahler and Greg Mann. > > > Bugs: MESOS-9979 > https://issues.apache.org/jira/browse/MESOS-9979 > > > Repository: mesos > > > Description > ------- > > Added docs for UPDATE_FRAMEWORK call. > > > Diffs > ----- > > docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774 > > > Diff: https://reviews.apache.org/r/72267/diff/1/ > > > Testing > ------- > > Checked rendering in Github: > https://github.com/asekretenko/mesos/blob/update_framework_doc/docs/scheduler-http-api.md > > > Thanks, > > Andrei Sekretenko > >
