----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72267/#review220644 -----------------------------------------------------------
Fix it, then Ship it! docs/scheduler-http-api.md Lines 544-546 (patched) <https://reviews.apache.org/r/72267/#comment309212> Hm.. this note applies to all of the field updates, but since it's only specified for capabilities, the reader will assume there is some semantic importance of the agent processing a framework capability update. This is probably something they have to understand specific to each particular capability. Perhaps instead just a general note up above about the possible response codes and when we send them? (i.e. it's just when the master processes it) docs/scheduler-http-api.md Lines 547 (patched) <https://reviews.apache.org/r/72267/#comment309213> Instead of "not specified", maybe we explain here that we don't disallow capability removal **BUT** there are currently no safeguards in place to prevent capability removal when the capability semantically can no longer be removed (e.g. if the framework started using shared resources, then SHARED_RESOURCES became a requirement, removing it should be disallowed but we don't currently protect against it). So: don't remove a capability, and if you *really really* need to, contact the dev@ or user@ list first. A link to the minimum capability stuff would be good too. - Benjamin Mahler On May 5, 2020, 7:06 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72267/ > ----------------------------------------------------------- > > (Updated May 5, 2020, 7:06 p.m.) > > > Review request for mesos, Benjamin Mahler and Greg Mann. > > > Bugs: MESOS-9979 > https://issues.apache.org/jira/browse/MESOS-9979 > > > Repository: mesos > > > Description > ------- > > Added docs for UPDATE_FRAMEWORK call. > > > Diffs > ----- > > docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774 > > > Diff: https://reviews.apache.org/r/72267/diff/2/ > > > Testing > ------- > > Checked rendering in Github: > https://github.com/asekretenko/mesos/blob/update_framework_doc/docs/scheduler-http-api.md > > > Thanks, > > Andrei Sekretenko > >
