----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72309/#review220202 -----------------------------------------------------------
Fix it, then Ship it! src/tests/containerizer/cgroups_isolator_tests.cpp Lines 389-390 (original), 389-390 (patched) <https://reviews.apache.org/r/72309/#comment308509> This comment needs to be updated since we do not measure CPU time now. src/tests/containerizer/cgroups_isolator_tests.cpp Line 551 (original), 526 (patched) <https://reviews.apache.org/r/72309/#comment308510> Ditto. - Qian Zhang On April 3, 2020, 1:51 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72309/ > ----------------------------------------------------------- > > (Updated April 3, 2020, 1:51 a.m.) > > > Review request for mesos, Andrei Budnik and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > This verification is error-prone and leads to flaky test > failures. It is sufficient to verify that the cgroup values > are set correctly. We will avoid going so far as to confirm > that the kernel's scheduler is honoring those values. > > > Diffs > ----- > > src/tests/containerizer/cgroups_isolator_tests.cpp > f4425f0b5fdecdad36fbd993eb75854b6764888b > > > Diff: https://reviews.apache.org/r/72309/diff/1/ > > > Testing > ------- > > `sudo bin/mesos-tests.sh --gtest_filter="*CFS*:-*DOCKER*"` > > > Thanks, > > Greg Mann > >
