----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72309/#review220234 -----------------------------------------------------------
Patch looks great! Reviews applied: [72309] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewbot On April 6, 2020, 10:15 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72309/ > ----------------------------------------------------------- > > (Updated April 6, 2020, 10:15 p.m.) > > > Review request for mesos, Andrei Budnik and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > This verification is error-prone and leads to flaky test > failures. It is sufficient to verify that the cgroup values > are set correctly. We will avoid going so far as to confirm > that the kernel's scheduler is honoring those values. > > > Diffs > ----- > > src/tests/containerizer/cgroups_isolator_tests.cpp > f4425f0b5fdecdad36fbd993eb75854b6764888b > > > Diff: https://reviews.apache.org/r/72309/diff/2/ > > > Testing > ------- > > `sudo bin/mesos-tests.sh --gtest_filter="*CFS*:-*DOCKER*"` > > > Thanks, > > Greg Mann > >
