----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72493/#review220714 -----------------------------------------------------------
3rdparty/libprocess/src/CMakeLists.txt Lines 135-137 (patched) <https://reviews.apache.org/r/72493/#comment309359> It doesn't seem right for these `MESOS_XXXX` variables to show up here in libprocess. Can we pass these destinations via some variables set up for that purpose? Ideally I think libprocess should also be buildable without Mesos, so we should probably have a default case to set up the installation if no destination directories are specified. - Greg Mann On May 11, 2020, 7:35 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72493/ > ----------------------------------------------------------- > > (Updated May 11, 2020, 7:35 p.m.) > > > Review request for mesos and Greg Mann. > > > Bugs: MESOS-6771 > https://issues.apache.org/jira/browse/MESOS-6771 > > > Repository: mesos > > > Description > ------- > > Added install target into libprocess cmake build. > > > Diffs > ----- > > 3rdparty/libprocess/src/CMakeLists.txt > 6fa1f60ea36424be3888c4e9aee575ab99180486 > > > Diff: https://reviews.apache.org/r/72493/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
