> On May 12, 2020, 4:42 a.m., Greg Mann wrote: > > 3rdparty/libprocess/src/CMakeLists.txt > > Lines 135-137 (patched) > > <https://reviews.apache.org/r/72493/diff/1/?file=2231388#file2231388line135> > > > > It doesn't seem right for these `MESOS_XXXX` variables to show up here > > in libprocess. Can we pass these destinations via some variables set up for > > that purpose? > > > > Ideally I think libprocess should also be buildable without Mesos, so > > we should probably have a default case to set up the installation if no > > destination directories are specified.
Replaced with dedicated variables. Making libprocess buildable with cmake without Mesos would be a major effort due to 3rdparties (I'm not even sure that automake currently does this correctly). I don't think it makes sense to make any additional steps in this direction right now. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72493/#review220714 ----------------------------------------------------------- On May 20, 2020, 9:38 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72493/ > ----------------------------------------------------------- > > (Updated May 20, 2020, 9:38 p.m.) > > > Review request for mesos and Greg Mann. > > > Bugs: MESOS-6771 > https://issues.apache.org/jira/browse/MESOS-6771 > > > Repository: mesos > > > Description > ------- > > Added install target into libprocess cmake build. > > > Diffs > ----- > > 3rdparty/libprocess/src/CMakeLists.txt > 6fa1f60ea36424be3888c4e9aee575ab99180486 > > > Diff: https://reviews.apache.org/r/72493/diff/2/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
