akornatskyy commented on a change in pull request #363:
URL: https://github.com/apache/mesos/pull/363#discussion_r424927884



##########
File path: 3rdparty/CMakeLists.txt
##########
@@ -99,6 +99,12 @@ else ()
   set(LIBRARY_SUFFIX ${CMAKE_STATIC_LIBRARY_SUFFIX})
 endif ()
 
+if (WIN32 AND BUILD_SHARED_LIBS)
+  set(3RDPARTY_LIBS_INSTALL_DIR ${MESOS_INSTALL_RUNTIME})
+else()
+  set(3RDPARTY_LIBS_INSTALL_DIR ${MESOS_INSTALL_LIBRARIES})
+endif()
+

Review comment:
       hm... just checked *master* branch of *apache/mesos* and 
*cmake_install_step_2* of *asekretenko/mesos* fork... the 3 commits are not 
there...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to