akornatskyy commented on a change in pull request #363:
URL: https://github.com/apache/mesos/pull/363#discussion_r427314104
##########
File path: 3rdparty/CMakeLists.txt
##########
@@ -512,6 +523,11 @@ ExternalProject_Add(
URL ${RAPIDJSON_URL}
URL_HASH ${RAPIDJSON_HASH})
+if (ENABLE_INSTALL_MODULE_DEPENDENCIES)
+ install(
+ DIRECTORY
${RAPIDJSON_CMAKE_ROOT}/src/rapidjson-${RAPIDJSON_VERSION}/include
+ DESTINATION .)
Review comment:
earlier agreed with @greggomann about option 1.
[here](https://github.com/apache/mesos/pull/363/commits/d90680c00e3332de088484aa162af8b90bebee0a)
is commit that fixes this inconsitency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
