> On Oct. 14, 2020, 12:54 a.m., Benjamin Mahler wrote: > > src/master/master.cpp > > Lines 2588-2598 (original) > > <https://reviews.apache.org/r/72955/diff/1/?file=2240633#file2240633line2589> > > > > Per above comment, did you mean to also move out the failover timeout > > validation, which looks to be a similarly stateless validation of the > > FrameworkInfo as this bit?
Thanks! I somehow missed that it is entirely stateless. Will send one more small patch. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72955/#review222039 ----------------------------------------------------------- On Oct. 12, 2020, 10:12 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72955/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2020, 10:12 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-10176 > https://issues.apache.org/jira/browse/MESOS-10176 > > > Repository: mesos > > > Description > ------- > > This merges three near-identical pieces of scattered code in SUBSCRIBE > and UPDATE_FRAMEWORK execution paths in the Master that validate > and construct parts of `allocator::FrameworkOptions` (the set of > suppressed roles and the offer constraints filter) into a single > function. > > This is a prerequisite to adding validation of offer constraint roles. > > > Diffs > ----- > > src/master/master.hpp 83d8190702ff25b5e3e9607d8250aa331aaad028 > src/master/master.cpp d6d3ea7e27539a65b601783eca2ac4e3b688f188 > > > Diff: https://reviews.apache.org/r/72955/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Andrei Sekretenko > >
