-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72955/
-----------------------------------------------------------
(Updated Oct. 14, 2020, 8:16 p.m.)
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-10176
https://issues.apache.org/jira/browse/MESOS-10176
Repository: mesos
Description
-------
This merges three near-identical pieces of scattered code in SUBSCRIBE
and UPDATE_FRAMEWORK execution paths in the Master that validate
and construct parts of `allocator::FrameworkOptions` (the set of
suppressed roles and the offer constraints filter) into a single
function.
This is a prerequisite to adding validation of offer constraint roles.
Diffs (updated)
-----
src/master/master.hpp 83d8190702ff25b5e3e9607d8250aa331aaad028
src/master/master.cpp d6d3ea7e27539a65b601783eca2ac4e3b688f188
src/master/validation.hpp 7fe8f087b322f8e77218f4dd9f9f75707afa3208
src/master/validation.cpp 5b1bcb5207aac0553bf9c1a0d89525c835393ccb
Diff: https://reviews.apache.org/r/72955/diff/2/
Changes: https://reviews.apache.org/r/72955/diff/1-2/
Testing
-------
make check
Thanks,
Andrei Sekretenko
