qianzhangxa commented on a change in pull request #398:
URL: https://github.com/apache/mesos/pull/398#discussion_r663003937



##########
File path: docs/configuration/agent.md
##########
@@ -1854,5 +1854,5 @@ quotas for container sandbox directories. Valid project 
IDs range from
 1 to max(uint32). (default `[5000-10000]`)
 </td>
 </tr>
-
 </table>
+

Review comment:
       I think we should leave this file untouched, right?

##########
File path: docs/mesos-containerizer.md
##########
@@ -66,3 +66,33 @@ Mesos supports the following built-in isolators.
 - [volume/secret](secrets.md#file-based-secrets)
 - [windows/cpu](isolators/windows.md#cpu-limits)
 - [windows/mem](isolators/windows.md#memory-limits)
+
+
+## Systemd Integration
+
+<table class="table table-striped">

Review comment:
       I am not sure if we need a table here, maybe just putting the following 
statement here should be good enough?
   
   > To prevent systemd from manipulating cgroups managed by the agent, it's 
recommended to add `Delegate` under `Service`, for example:
   > ```
   > [Service]
   > Delegate=true
   > ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to