qianzhangxa commented on a change in pull request #398:
URL: https://github.com/apache/mesos/pull/398#discussion_r668711982



##########
File path: docs/mesos-containerizer.md
##########
@@ -66,3 +66,14 @@ Mesos supports the following built-in isolators.
 - [volume/secret](secrets.md#file-based-secrets)
 - [windows/cpu](isolators/windows.md#cpu-limits)
 - [windows/mem](isolators/windows.md#memory-limits)
+
+

Review comment:
       I think we just need one blank line rather than two.

##########
File path: docs/mesos-containerizer.md
##########
@@ -66,3 +66,14 @@ Mesos supports the following built-in isolators.
 - [volume/secret](secrets.md#file-based-secrets)
 - [windows/cpu](isolators/windows.md#cpu-limits)
 - [windows/mem](isolators/windows.md#memory-limits)
+
+
+## Systemd Integration
+
+To prevent systemd from manipulating cgroups managed by the agent, it's 
recommended to add 'Delegate' under 'Service'.
+Example:

Review comment:
       Better to change
   > it's recommended to add 'Delegate' under 'Service'.
   > Example:
   
   to
   
   > it's recommended to add `Delegate` under `Service` in the service unit 
file of Mesos agent, for example:




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to