----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75086/#review226669 -----------------------------------------------------------
Bad patch! Reviews applied: [75086] Failed command: cd .. && /usr/bin/python3 support/apply-reviews.py -n -r 75086 Error: 2024-07-12 21:00:14 URL:https://reviews.apache.org/r/75086/diff/raw/ [16613/16613] -> "75086.patch" [1] 75086.patch:76: trailing whitespace. warning: 1 line adds whitespace errors. Committer identity unknown *** Please tell me who you are. Run git config --global user.email "[email protected]" git config --global user.name "Your Name" to set your account's default identity. Omit --global to set the identity only in this repository. fatal: empty ident name (for <[email protected]>) not allowed Full log: https://ci-builds.apache.org/job/Mesos/job/Mesos-Reviewbot/33496/console - Mesos Reviewbot On July 12, 2024, 6:52 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75086/ > ----------------------------------------------------------- > > (Updated July 12, 2024, 6:52 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > In systems with systemd version above 242, there is a potential data > race where udev will try to update the MAC address of the device at the > same time as us if the systemd's MacAddressPolicy is set to 'persistent'. > To prevent udev from trying to set the veth device's MAC address by > itself, we must set the device MAC address on creation so that > addr_assign_type will be set to NET_ADDR_SET, which prevents udev from > attempting to change the MAC address of the veth device. > see: > https://github.com/torvalds/linux/commit/2afb9b533423a9b97f84181e773cf9361d98fed6 > see: > https://lore.kernel.org/netdev/cahxsexy8lkzocbdbzss_vjopc_tqmyzm87kc192hpmuhmcq...@mail.gmail.com/T/ > > > Diffs > ----- > > src/linux/routing/link/veth.hpp a4acbe9b5c7dd77f3736fc5348743081c04cabf1 > src/linux/routing/link/veth.cpp 6aeb95e710098056b464c2088b0b60cdd3fe3f65 > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp > 3b3b899fb43364f545eb9748ab4215fd5b2e2895 > src/tests/containerizer/routing_tests.cpp > c9fa2e86a52873575c77bd0984d4eaba34282eff > > > Diff: https://reviews.apache.org/r/75086/diff/1/ > > > Testing > ------- > > Added test to check that veth::create with a target MAC address is able to > create a link with that target MAC address. > RoutingVethTest and PortMappingIsolatorTest pass (except > ROOT_ContainerARPExternal which has always failed) > > > Thanks, > > Jason Zhou > >
