-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75086/
-----------------------------------------------------------
(Updated July 15, 2024, 2:42 p.m.)
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-10243
https://issues.apache.org/jira/browse/MESOS-10243
Repository: mesos
Description
-------
In systems with systemd version above 242, there is a potential data
race where udev will try to update the MAC address of the device at the
same time as us if the systemd's MacAddressPolicy is set to 'persistent'.
To prevent udev from trying to set the veth device's MAC address by
itself, we must set the device MAC address on creation so that
addr_assign_type will be set to NET_ADDR_SET, which prevents udev from
attempting to change the MAC address of the veth device.
see:
https://github.com/torvalds/linux/commit/2afb9b533423a9b97f84181e773cf9361d98fed6
see:
https://lore.kernel.org/netdev/cahxsexy8lkzocbdbzss_vjopc_tqmyzm87kc192hpmuhmcq...@mail.gmail.com/T/
see: https://issues.apache.org/jira/browse/MESOS-10243
Diffs (updated)
-----
src/linux/routing/link/link.hpp 09790f31711cf271567176d3d67ed51025d2d712
src/linux/routing/link/link.cpp bb97e328175dea5c0937defce2e234b0de3cfe32
src/linux/routing/link/veth.hpp a4acbe9b5c7dd77f3736fc5348743081c04cabf1
src/linux/routing/link/veth.cpp 6aeb95e710098056b464c2088b0b60cdd3fe3f65
src/slave/containerizer/mesos/isolators/network/port_mapping.cpp
3b3b899fb43364f545eb9748ab4215fd5b2e2895
src/tests/containerizer/routing_tests.cpp
c9fa2e86a52873575c77bd0984d4eaba34282eff
Diff: https://reviews.apache.org/r/75086/diff/4/
Changes: https://reviews.apache.org/r/75086/diff/3-4/
Testing
-------
Added test to check that veth::create with a target MAC address is able to
create a link with that target MAC address.
RoutingVethTest and PortMappingIsolatorTest pass (except
ROOT_ContainerARPExternal which has always failed)
Thanks,
Jason Zhou
