andreaspeters commented on code in PR #586:
URL: https://github.com/apache/mesos/pull/586#discussion_r1943641141
##########
src/launcher/docker_executor.cpp:
##########
@@ -148,6 +148,14 @@ int main(int argc, char** argv)
<< flags.usage("Missing required option --mapped_directory");
}
+ if (flags.network_cni_plugins_dir.isNone()) {
+ flags.network_cni_plugins_dir = "/usr/lib/cni/";
+ }
+
+ if (flags.network_cni_config_dir.isNone()) {
+ flags.network_cni_config_dir = "/etc/mesos/cni/net.d";
+ }
Review Comment:
👍 your right. I think the behavior should be like with the mesos executor. I
will change that to:
- It has to be set when we want to use CNI
- No default values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
