andreaspeters commented on code in PR #586:
URL: https://github.com/apache/mesos/pull/586#discussion_r1943655611
##########
src/docker/executor.cpp:
##########
@@ -318,7 +329,26 @@ class DockerExecutorProcess : public
ProtobufProcess<DockerExecutorProcess>
}
};
- if (container.ipAddress.isSome()) {
+ bool useCNI = false;
+#ifdef __linux__
+ if (network_cni_config_dir.size() > 0 &&
network_cni_plugins_dir.size() > 0) {
Review Comment:
> !x.empty()
Oh... much better, thanks. :-)
> Also, does it make sense for only one to be set?
I don't think so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
