Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/42#discussion_r10685165
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.scheduler
+
+import java.util.concurrent.LinkedBlockingQueue
+
+import org.apache.spark.Logging
+
+/** Asynchronously passes SparkListenerEvents to registered
SparkListeners. */
+private[spark] class LiveListenerBus extends SparkListenerBus with Logging
{
+
+ /* Cap the capacity of the SparkListenerEvent queue so we get an
explicit error (rather than
+ * an OOM exception) if it's perpetually being added to more quickly
than it's being drained. */
+ private val EVENT_QUEUE_CAPACITY = 10000
+ private val eventQueue = new
LinkedBlockingQueue[SparkListenerEvent](EVENT_QUEUE_CAPACITY)
+ private var queueFullErrorMessageLogged = false
+
+ /**
+ * Create a new daemon thread to listen for events. Until this thread
has started, all posted
--- End diff --
The scaladoc here might be better focusing on the external interface for
users rather than the fact that it launches a thread. For instance we could
refactor this some day to not launch a separate thread and we'd still preserve
the semantics of `start`. So maybe remove the first sentence.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
