Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/88#discussion_r10739107
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/SVD.scala ---
@@ -38,18 +40,49 @@ class SVD {
this
}
- /**
+ /**
+ * How small of a singular value is considered zero?
+ */
+ def setRCOND(rcond: Double): SVD = {
--- End diff --
Sorry, my bad here. `RCOND` (reciprocal condition number) is used in
LAPACK. It is not an absolute value but relative to the largest singular value.
We should give the method a more precise name instead of `setRCOND`. I would
suggest `setReciprocalConditionNumber` and explain what it is in the doc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
