Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/88#issuecomment-38024310
Hi @rezazadeh
Thanks for working on this! I can't wait for this to be merged and improve
the coverage on common ml algorithms in mllib.
I am not really qualified to review the ml/algorithmic part of this PR, but
I went through it to cover some coding style and readability issues. We really
need to work on improving our Scala style checker to help catch some common
pitfalls automatically, but before we have a fully function checker, it would
be great if you can pay more attention to the style of the code. We do have a
style guide for contributors at:
https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide
http://docs.scala-lang.org/style/
Again, really thanks for doing this. It's super cool to have these.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
