Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/164#discussion_r10829857
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/util/WholeTextFileSuite.scala ---
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.mllib.util
+
+
+import java.io.{BufferedReader, DataOutputStream, FileOutputStream,
InputStreamReader}
+import java.nio.file.Files
+import java.nio.file.{Path => JPath}
+import java.nio.file.{Paths => JPaths}
+
+import scala.collection.immutable.IndexedSeq
+
+import org.scalatest.BeforeAndAfterAll
+import org.scalatest.FunSuite
+
+import org.apache.hadoop.fs.FileSystem
+import org.apache.hadoop.fs.Path
+import org.apache.hadoop.hdfs.MiniDFSCluster
+import org.apache.hadoop.io.Text
+
+import org.apache.spark.mllib.util.MLUtils._
+import org.apache.spark.SparkContext
+
+/**
+ * Tests HDFS IO and local disk IO of [[wholeTextFile]] in MLutils. HDFS
tests create a mock DFS in
+ * memory, while local disk test create a temp directory. All these
temporal storages are deleted
+ * in the end.
+ */
+
+class WholeTextFileSuite extends FunSuite with BeforeAndAfterAll {
--- End diff --
Yep, it will be much easy if we just test `WholeTextFileRecordReader`
alone. I can construct a `CombineFileSplit` and test it. The correctness of
reading files from HDFS and native disk is guaranteed by other tests, I think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
